[webkit-reviews] review denied: [Bug 45340] Support SerializedScriptValue in WebKit2 : [Attachment 66802] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Oliver Hunt <oliver at apple.com>'s request
for review:
Bug 45340: Support SerializedScriptValue in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=45340

Attachment 66802: Patch
https://bugs.webkit.org/attachment.cgi?id=66802&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66802&action=prettypatch

> WebKit2/UIProcess/API/C/WKAPICast.h:107
>  template<> struct ImplTypeInfo<WebNavigationData*>		   { typedef
WKNavi
>  template<> struct ImplTypeInfo<WebPageNamespace*>		   { typedef
WKPageNamespaceRef APIType; };
>  template<> struct ImplTypeInfo<WebPageProxy*>		   { typedef
WKPageRef APIType; };
>  template<> struct ImplTypeInfo<WebPreferences*>		   { typedef
WKPreferencesRef APIType; };
> +template<> struct ImplTypeInfo<WebSerializedScriptValue*>	   { typedef
WKSerializedScriptValueRef APIType; };
>  template<> struct ImplTypeInfo<WebString*>			   { typedef
WKStringRef APIType; };
>  template<> struct ImplTypeInfo<WebURL*>			   { typedef
WKURLRef APIType; };
>  template<> struct ImplTypeInfo<WebURLRequest*>		   { typedef
WKURLRequestRef APIType; };
It looks like you are missing the APITypeInfo definition here.

> WebKit2/UIProcess/API/C/WKSerializedScriptValue.cpp:43
> +JSValueRef WKSerializedScriptValueDeserialize(WKSerializedScriptValueRef
scriptValueRef, JSContextRef contextRef, JSValueRef* exception)
> +{
> +    return toWK(serializedValueRef)->deserialize(contextRef, exceptionRef);
> +}
This won't compile.  You need to change serializedValueRef to scriptValueRef.

I believe you are also missing the WebKit2.pro and WebKit2.vcproj changes.