[webkit-reviews] review granted: [Bug 45204] Add AudioArray.h : [Attachment 66547] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 45204: Add AudioArray.h
https://bugs.webkit.org/show_bug.cgi?id=45204

Attachment 66547: Patch
https://bugs.webkit.org/attachment.cgi?id=66547&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Looks good to me. One comment not necessarily requiring action.

View in context:
https://bugs.webkit.org/attachment.cgi?id=66547&action=prettypatch

> WebCore/platform/audio/AudioArray.h:55
> +    void copyToRange(T* sourceData, unsigned start, unsigned end)
If you have situations elsewhere in your code where you would pass e.g.
AudioFloatArray.data() as the first argument to copyToRange, then it would be
good to add another overloaded version of copyToRange which can also verify
that the source array has enough elements to cover the copy operation.