[webkit-reviews] review granted: [Bug 45315] Enable incremental results.json generation for non-layout tests. : [Attachment 66748] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 45315: Enable incremental results.json generation for non-layout tests.
https://bugs.webkit.org/show_bug.cgi?id=45315

Attachment 66748: Patch
https://bugs.webkit.org/attachment.cgi?id=66748&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66748&action=prettypatch

Just a few nits.

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator
.py:296
> +		   print results_file_url
Did you mean to include this?

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator
.py:532
> +		       self._builder_name, self._test_results_server)
Indentation is off. Have a couple extra spaces.

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator
.py:595
> +	   # Generate the JSON with incrementa flag enabled.
Typo: incrementa