[webkit-reviews] review granted: [Bug 45133] [chromium] Make a public flag for how DRT generates bitmaps on Linux : [Attachment 66424] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Tony Chang
<tony at chromium.org>'s request for review:
Bug 45133: [chromium] Make a public flag for how DRT generates bitmaps on Linux
https://bugs.webkit.org/show_bug.cgi?id=45133

Attachment 66424: Patch
https://bugs.webkit.org/attachment.cgi?id=66424&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66424&action=prettypatch

> WebKit/chromium/public/WebKit.h:60
> +WEBKIT_API bool makeLinuxChecksumOpaque();
this method name sounds like something that is a command.  hey you, go make it
opaque.
but the signature looks more like a getter.  how about "isLinuxChecksumOpaque"?


that said, i'm not sure what it means for a checksum to be opaque.  hmm...  how
about
"areLayoutTestImagesOpaque"?

R=me modulo this re-naming suggestion