[webkit-reviews] review denied: [Bug 45192] Provide a way to trigger a <select multiple> onchange event on changes : [Attachment 66570] [PATCH] Automated Test

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Joseph Pecoraro <joepeck at webkit.org>'s
request for review:
Bug 45192: Provide a way to trigger a <select multiple> onchange event on
changes
https://bugs.webkit.org/show_bug.cgi?id=45192

Attachment 66570: [PATCH] Automated Test
https://bugs.webkit.org/attachment.cgi?id=66570&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Great to add a test for this!

This DOMHTMLController object doesn’t seem to have too much to do with DOM,
except inasmuch all JavaScript functions are part of "DOM". We have lots of
functions like this on the main layout test controller. I’m not sure why we are
making a new object for these functions. For example, the execCommand,
isCommandEnabled, elementDoesAutoCompleteForElementWithId,
counterValueForElementById, computedStyleIncludingVisitedInfo, and
markerTextForListItem functions.

Maybe it would be better to make this part of a "form testing" controller, or a
"user input simulating" type controller, or maybe make it part of
LayoutTestController since many other functions like this are already there.

HTML should be in all caps (or all lower case in strange cases), not spelled
"Html".

The DOM prefix is reserved for WebKit use for the Objective-C DOM bindings, so
it’s not great to have DumpRenderTree use this prefix for one of its classes.