[webkit-reviews] review requested: [Bug 45318] Complex Path FontCache does not handle SmallCaps properly : [Attachment 66754] Patch to add small caps to font cache

[bugzilla-daemon at webkit.org]

Gary Simmons <gsimmons at rim.com> has asked  for review:
Bug 45318: Complex Path FontCache does not handle SmallCaps properly
https://bugs.webkit.org/show_bug.cgi?id=45318

Attachment 66754: Patch to add small caps to font cache
https://bugs.webkit.org/attachment.cgi?id=66754&action=review

------- Additional Comments from Gary Simmons <gsimmons at rim.com>
Overview: 

When rendering with FAST_PATH turned off, the complex path for small caps data
directly requests a FontPlatformData with SmallCapsVariant. Currently the
SmallCapsVariant and the PlainVariant will have the same hash and occupy same
space in the font cache resulting in incorrect rendering (always Small Caps or
always plain)

Steps to Reproduce:

1) Build with fast path disabled
2) Load a webpage using small caps of a particular font
3) Load another page with exactly the same font but without small caps

Expected Results:

The small caps page will have small caps, the plain page will have plain.

Actual Results:

Both pages have Small Caps (likewise if steps 2 and 3 are reversed both pages
will have plain).