[webkit-reviews] review denied: [Bug 45020] Support "block-flow" and "writing-mode": interpret properties into RenderStyle : [Attachment 66604] Modified patch. Incorporated feedback from Adele and Dave.

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Takumi Takano
<takano1 at asia.apple.com>'s request for review:
Bug 45020: Support "block-flow" and "writing-mode": interpret properties into
RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=45020

Attachment 66604: Modified patch. Incorporated feedback from Adele and Dave.
https://bugs.webkit.org/attachment.cgi?id=66604&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
(1) You need to move all of the value keywords for writing-mode and block-flow
out of SVGCSSValueKeywords.in, so that your code will compile even when
ENABLE(SVG) is false.  I'm not sure what some of them are doing in that file
anyway.  Just move them all over to the main CSS keywords file.

(2) You need to patch the RenderStyle::diff() method to make sure changes in
block-flow trigger a layout.

(3) I'd still like to see computed style support added
(CSSComputedStyleDeclaration.cpp).

(4) Once you add computed style support in (3), you can add some layout tests
to this patch as well.	I'd suggest fast/text/vertical as a good place for new
tests.