[webkit-reviews] review denied: [Bug 45268] Symbian scoping in Qt build profile is wrong : [Attachment 66644] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 7 08:05:16 PDT 2010


Simon Hausmann <hausmann at webkit.org> has denied Kristian Amlie
<kristian.amlie at nokia.com>'s request for review:
Bug 45268: Symbian scoping in Qt build profile is wrong
https://bugs.webkit.org/show_bug.cgi?id=45268

Attachment 66644: Patch
https://bugs.webkit.org/attachment.cgi?id=66644&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66644&action=prettypatch

Patch looks okay, but r- because of missing url to bugzilla in the ChangeLog
and missing [Qt] as suffix "Fixed incorrect..." should be "[Qt] Fixed
incorrect". Could you fix that? :)


More information about the webkit-reviews mailing list