[webkit-reviews] review denied: [Bug 45292] V8 generated code is missing include of V8BindingMacros.h for STRING_TO_V8PARAMETER_EXCEPTION_BLOCK : [Attachment 66711] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 7 06:25:35 PDT 2010


Steve Block <steveblock at google.com> has denied	review:
Bug 45292: V8 generated code is missing include of V8BindingMacros.h for
STRING_TO_V8PARAMETER_EXCEPTION_BLOCK
https://bugs.webkit.org/show_bug.cgi?id=45292

Attachment 66711: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=66711&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
> +	   Compile fix for Android. Explicitly add needed header for
> +	   STRING_TO_V8PARAMETER_EXCEPTION_BLOCK as they do not get included
through
> +	   other headers on Android.
Need a bug URL

Remember to set r? and cq? if you want the patch to be reviewed and added to
the commit-queue.


More information about the webkit-reviews mailing list