[webkit-reviews] review requested: [Bug 45289] Refactoring multiline comments in the lexer : [Attachment 66713] patch

[bugzilla-daemon at webkit.org]

Zoltan Herczeg <zherczeg at webkit.org> has asked	for review:
Bug 45289: Refactoring multiline comments in the lexer
https://bugs.webkit.org/show_bug.cgi?id=45289

Attachment 66713: patch
https://bugs.webkit.org/attachment.cgi?id=66713&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
--parse-only reports a big change, but I am unsure it is really caused by the
patch. Who knows...

=============================================================================

** TOTAL **:		       1.063x as fast	 33.6ms +/- 1.5%   31.6ms +/-
1.6%	 significant

=============================================================================

  jquery:		       -		  5.1ms +/- 4.4%    4.9ms +/-
4.6%
    1.3.2:		       -		  5.1ms +/- 4.4%    4.9ms +/-
4.6%

  mootools:		       1.080x as fast	  5.4ms +/- 6.8%    5.0ms +/-
0.0%	 significant
    1.2.2-core-nc:	       1.080x as fast	  5.4ms +/- 6.8%    5.0ms +/-
0.0%	 significant

  prototype:		       1.067x as fast	  6.4ms +/- 5.8%    6.0ms +/-
0.0%	 significant
    1.6.0.3:		       1.067x as fast	  6.4ms +/- 5.8%    6.0ms +/-
0.0%	 significant

  concat:		       1.064x as fast	 16.7ms +/- 2.1%   15.7ms +/-
2.2%	 significant
    jquery-mootools-prototype: 1.064x as fast	 16.7ms +/- 2.1%   15.7ms +/-
2.2%	 significant

SS has no change:

=============================================================================

** TOTAL **:	       -		 523.1ms +/- 0.6%   521.2ms +/- 0.5%

=============================================================================