[webkit-reviews] review denied: [Bug 45181] Ignore programmatic clicks on speech input button. : [Attachment 66702] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 7 04:28:58 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has denied Satish Sampath
<satish at chromium.org>'s request for review:
Bug 45181: Ignore programmatic clicks on speech input button.
https://bugs.webkit.org/show_bug.cgi?id=45181

Attachment 66702: Patch
https://bugs.webkit.org/attachment.cgi?id=66702&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66702&action=prettypatch

> LayoutTests/fast/speech/speech-button-ignore-generated-events.html:59
> +	       setTimeout(setupDispatchEventTest, 50);
There must be a way to not use a timeout.  Flaky tests are a MAJOR problem in
Chrome and WebKit.  We should avoid adding more at all costs.


More information about the webkit-reviews mailing list