[webkit-reviews] review denied: [Bug 43954] An individual renderer should be assigned to each SVGFE*Element class : [Attachment 66699] Path for Dirk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 7 03:31:50 PDT 2010


Dirk Schulze <krit at webkit.org> has denied Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 43954: An individual renderer should be assigned to each SVGFE*Element
class
https://bugs.webkit.org/show_bug.cgi?id=43954

Attachment 66699: Path for Dirk
https://bugs.webkit.org/attachment.cgi?id=66699&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66699&action=prettypatch

> WebCore/svg/SVGAllInOne.cpp:29
> +#include "RenderSVGResourceFilterPrimitive.cpp"
You added it to the wrong list. Take
http://trac.webkit.org/browser/trunk/WebCore/rendering/RenderSVGAllInOne.cpp.
This should work as well. Can you test it again please?


More information about the webkit-reviews mailing list