[webkit-reviews] review denied: [Bug 45181] Ignore programmatic clicks on speech input button. : [Attachment 66639] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Satish Sampath
<satish at chromium.org>'s request for review:
Bug 45181: Ignore programmatic clicks on speech input button.
https://bugs.webkit.org/show_bug.cgi?id=45181

Attachment 66639: Patch
https://bugs.webkit.org/attachment.cgi?id=66639&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66639&action=prettypatch

> LayoutTests/fast/speech/speech-button-ignore-generated-events.html:13
> +// In this test, we send a generated click event via the dispatchEvent
interface which is
Put this text in the body of the page.

> LayoutTests/fast/speech/speech-button-ignore-generated-events.html:17
> +// ** NOTE: If this test fails, please check the following:
Your target audience is people changing the test or re-baselining it--not those
looking into why it's failing.	The point should be that if the implementation
changes a lot, the calculated click point may no longer be the button.	And
this should explain to people how to manually test it (while being fairly
generic since code will move around over time).