[webkit-reviews] review denied: [Bug 44950] [WML] Add create functions to WML : [Attachment 66693] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 7 02:01:16 PDT 2010


Dirk Schulze <krit at webkit.org> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 44950: [WML]  Add create functions to WML
https://bugs.webkit.org/show_bug.cgi?id=44950

Attachment 66693: Patch
https://bugs.webkit.org/attachment.cgi?id=66693&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66693&action=prettypatch

> WebCore/wml/WMLIntrinsicEvent.h:38
> +    static PassRefPtr<WMLIntrinsicEvent> create(const QualifiedName&,
Document*);
> +
I'm realy sorry, I looked at Maciejs patch again. I think the new constructor
doesn't make sense. Maciej may made a mistake here. The new create function and
the new constructor are wrong in this context. Please undo the changes except
of the coding style change and delete PassRefPtr<WMLIntrinsicEvent>
create(const QualifiedName&, Document*); from WebCore/wml/WMLIntrinsicEvent.cpp
instead.


More information about the webkit-reviews mailing list