[webkit-reviews] review denied: [Bug 44950] [WML] Add create functions to WML : [Attachment 66676] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 7 00:02:22 PDT 2010
Dirk Schulze <krit at webkit.org> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 44950: [WML] Add create functions to WML
https://bugs.webkit.org/show_bug.cgi?id=44950
Attachment 66676: Patch
https://bugs.webkit.org/attachment.cgi?id=66676&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66676&action=prettypatch
> WebCore/wml/WMLFormControlElement.h:34
> public:
> + static PassRefPtr<WMLFormControlElement> create(const QualifiedName&,
Document*);
> +
> WMLFormControlElement(const QualifiedName&, Document*);
> virtual ~WMLFormControlElement();
sorry, I thougt it was clear now. The Ctor: WMLFormControlElement(const
QualifiedName&, Document*); should be private now! The same way like you did it
for WMLIntrinsicEvent.
Rest looks fine.
More information about the webkit-reviews
mailing list