[webkit-reviews] review canceled: [Bug 45129] [GTK] ignore po~ files in .gitignore : [Attachment 66409] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 6 12:52:08 PDT 2010


arno. <arno at renevier.net> has canceled arno. <arno at renevier.net>'s request for
review:
Bug 45129: [GTK] ignore po~ files in .gitignore
https://bugs.webkit.org/show_bug.cgi?id=45129

Attachment 66409: patch v1
https://bugs.webkit.org/attachment.cgi?id=66409&action=review

------- Additional Comments from arno. <arno at renevier.net>
(In reply to comment #5)
> Two ideas: why not ignore all *~ files, given those are usually generated by
popular editors such as Emacs? Also, we should ignore WebKit/gtk/po/*.pot,
because the name of the pot file may change depending on the version of the
library that is being build (with gtk2 or 3)

Should we ignore *~ globally or just for gtk ?
here is an updated patch ignoring *~ globally.


More information about the webkit-reviews mailing list