[webkit-reviews] review denied: [Bug 44950] [WML] Add create functions to WML : [Attachment 66643] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 6 11:15:14 PDT 2010


Dirk Schulze <krit at webkit.org> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 44950: [WML]  Add create functions to WML
https://bugs.webkit.org/show_bug.cgi?id=44950

Attachment 66643: Patch
https://bugs.webkit.org/attachment.cgi?id=66643&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66643&action=prettypatch

> WebCore/wml/WMLFormControlElement.h:48
> +    static PassRefPtr<WMLFormControlElement> create(const QualifiedName&,
Document*);
My first comment was maybe a bit confusing. 'create' should be public and the
CTor should be private :-)

Looks like the WML code is realy bad maintened. Good catches!

Please go a bit more into details in the Changelog. Also mention which commit
broke WML and that this patch tries to get WML building again.

You'll get r=me after you uploaded a new version with the changes above.


More information about the webkit-reviews mailing list