[webkit-reviews] review granted: [Bug 45262] Web Inspector: upstream two debugger tests : [Attachment 66641] Remove old tests from chromium

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 45262: Web Inspector: upstream two debugger tests
https://bugs.webkit.org/show_bug.cgi?id=45262

Attachment 66641: Remove old tests from chromium
https://bugs.webkit.org/attachment.cgi?id=66641&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66641&action=prettypatch

> LayoutTests/inspector/debugger-pause-on-breakpoint.html:31
> +	   InspectorTest.addResult("line: " + callFrames[0].line + ", function:
" + callFrames[0].functionName);
Please use InspectorTest.captureStackTrace for this.

> LayoutTests/inspector/debugger-pause-on-exception.html:36
> +	   InspectorTest.addResult("line: " + callFrames[0].line + ", function:
" + callFrames[0].functionName);
Please use InspectorTest.captureStackTrace for this.

> WebKit/chromium/src/js/Tests.js:-634
> -TestSuite.prototype.testSetBreakpoint = function()
Make sure to remove Chromium code that invokes them before landing this patch.
cq- for this.