[webkit-reviews] review denied: [Bug 45181] Ignore programmatic clicks on speech input button. : [Attachment 66633] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Satish Sampath
<satish at chromium.org>'s request for review:
Bug 45181: Ignore programmatic clicks on speech input button.
https://bugs.webkit.org/show_bug.cgi?id=45181

Attachment 66633: Patch
https://bugs.webkit.org/attachment.cgi?id=66633&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66633&action=prettypatch

> LayoutTests/fast/speech/speech-button-ignore-generated-events-expected.txt:9
> +TEST COMPLETE
Add newline at end.

> LayoutTests/fast/speech/speech-button-ignore-generated-events.html:20
> +    var input = document.createElement('input');
put this in the page itself

> LayoutTests/fast/speech/speech-button-ignore-generated-events.html:32
> +    }, 500);
this is flaky!!!!

is there some number of setTimeouts that makes this deterministic?   or
something like that?

> LayoutTests/fast/speech/speech-button-ignore-generated-events.html:41
> +    event.initMouseEvent('click', true, true, window, 1, pageX, pageY,
clientX, clientY,
is there any way to know for sure that this fired on the correct element?



sorry i'm being so nit picky, but this is a very important test  :-)