[webkit-reviews] review denied: [Bug 44950] [WML] Add create functions to WML : [Attachment 66051] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 44950: [WML]  Add create functions to WML
https://bugs.webkit.org/show_bug.cgi?id=44950

Attachment 66051: Patch
https://bugs.webkit.org/attachment.cgi?id=66051&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66051&action=prettypatch

> WebCore/wml/WMLFormControlElement.h:33
>      WMLFormControlElement(const QualifiedName&, Document*);
should be private now.

Also don't we miss PassRefPtr<WMLFormControlElement> create(..) in the cpp now?


> WebCore/wml/WMLIntrinsicEvent.h:37
> +    static PassRefPtr<WMLIntrinsicEvent> create(const QualifiedName&,
Document*);
Dito. Where is this function located? Did you miss it? I didn't see a
WMLIntrinsicEvent(const QualifiedName&, Document*) call before. Do we need this
here at all?