[webkit-reviews] review granted: [Bug 43954] An individual renderer should be assigned to each SVGFE*Element class : [Attachment 66627] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 6 05:37:26 PDT 2010
Dirk Schulze <krit at webkit.org> has granted Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 43954: An individual renderer should be assigned to each SVGFE*Element
class
https://bugs.webkit.org/show_bug.cgi?id=43954
Attachment 66627: patch
https://bugs.webkit.org/attachment.cgi?id=66627&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66627&action=prettypatch
> WebCore/rendering/RenderObject.h:324
> virtual bool isSVGResourceContainer() const { return false; }
> virtual bool isSVGShadowTreeRootContainer() const { return false; }
> + virtual bool isRenderSVGResourceFilterPrimitive() const { return false;
}
Maybe we should name this isSVGResourceFilterPrimitive to be consistent with
the other function names.
Please change the name everywhere you're using this function. Otherwise looks
great. r=me with this change.
More information about the webkit-reviews
mailing list