[webkit-reviews] review denied: [Bug 45181] Ignore programmatic clicks on speech input button. : [Attachment 66621] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 6 04:37:49 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has denied Satish Sampath
<satish at chromium.org>'s request for review:
Bug 45181: Ignore programmatic clicks on speech input button.
https://bugs.webkit.org/show_bug.cgi?id=45181

Attachment 66621: Patch
https://bugs.webkit.org/attachment.cgi?id=66621&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Apparently using script-tests for stuff that involves WebCore is no longer in
vogue.	Please remove TEMPLATE and merge the .js file into the generated html
file, delete any boilerplate you might not need, and just check that in.  Add
the element to the html file directly rather than dynamically

In the js file, use 4 space tabs.

The part that tests programatic clicks don't work is the most important thing
here.  Definitely make sure it works even when a layout test controller isn't
present.  Maybe even split into two tests?


More information about the webkit-reviews mailing list