[webkit-reviews] review denied: [Bug 43529] [Qt] can't replay a video via Phonon : [Attachment 66616] Proposed Patch : replaying a video

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 6 03:42:07 PDT 2010


Tor Arne Vestbø <vestbo at webkit.org> has denied SH <sukhyun.kim at nokia.com>'s
request for review:
Bug 43529: [Qt] can't replay a video via Phonon
https://bugs.webkit.org/show_bug.cgi?id=43529

Attachment 66616: Proposed Patch : replaying a video 
https://bugs.webkit.org/attachment.cgi?id=66616&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
This should be handled by the following snippet from
HTMLMediaElement::playInternal()

 if (endedPlayback()) {
	ExceptionCode unused;
	seek(0, unused);
    }

Why isn't it?

Also, the test should be in the form of a layout-test if there are none testing
for this case (there should be).

FYI the phonon backend is not really maintained, you'd be better off looking at
the QtMultimedia backend and helping out there.


More information about the webkit-reviews mailing list