[webkit-reviews] review granted: [Bug 45119] Implement HTML5 definition of document.readyState : [Attachment 66605] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 45119: Implement HTML5 definition of document.readyState
https://bugs.webkit.org/show_bug.cgi?id=45119

Attachment 66605: Patch
https://bugs.webkit.org/attachment.cgi?id=66605&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66605&action=prettypatch

Looks great.  Please be on the lookout for any compat issues.

> LayoutTests/ChangeLog:9
> +	   * fast/dom/Document/readystate-expected.txt: Added.
> +	   * fast/dom/Document/readystate.html: Added. Reads readyState inline
script, external script, deferred script, DOMContentLoaded, onload, and dynamic
post-onload script.
Out of curiosity, did you cross-test this with other browsers?

> LayoutTests/fast/dom/Document/readystate.html:5
> +<link rel="stylesheet" href="../../js/resources/js-test-style.css">
> +<script src="../../js/resources/js-test-pre.js"></script>
Woah, crazy.  It's like a script test that doesn't use an external JS file.  In
my ideal world, doing something like this would be as easy as dump-as-markup:
just add a script tag.

> WebCore/dom/Document.cpp:962
> +    switch (m_readyState) {
> +    case Loading:
> +	   return "loading";
> +    case Interactive:
> +	   return "interactive";
> +    case Complete:
> +	   return "complete";
Should we use DECLARE_STATIC_LOCAL so we don't have to create these string
objects every time this API is called?