[webkit-reviews] review denied: [Bug 45147] [Qt] V8 port for QT platform: Plugin changes : [Attachment 66454] Plugin changes

[bugzilla-daemon at webkit.org]

Andreas Kling <andreas.kling at nokia.com> has denied Vlad <vladbph at gmail.com>'s
request for review:
Bug 45147: [Qt] V8 port for QT platform: Plugin changes
https://bugs.webkit.org/show_bug.cgi?id=45147

Attachment 66454: Plugin changes
https://bugs.webkit.org/attachment.cgi?id=66454&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
> +#if PLATFORM(QT)
> +    #undef True
> +    #undef False

Why is this needed? There's no reference to it in the ChangeLog.

>  #if USE(JSC)
>	   ScriptState* scriptState =
parentFrame->script()->globalObject(pluginWorld())->globalExec();
> -#elif USE(V8)
> +#else
>	   ScriptState* scriptState = 0; // Not used with V8
>  #endif

This part should be left alone.

> +// definition fits V8 and JSC

Unnecessary comment.
More importantly though, bindingInstance() will now be compiled but never used
for Chromium. We should be nice and use an "#if USE(JSC) || (USE(V8) &&
!PLATFORM(CHROMIUM))" guard.

> +#else
> +#include "V8NPObject.h"
> +#endif

Should be "#elif USE(V8)".

r- because of the bindingInstance() on Chromium thing.