[webkit-reviews] review denied: [Bug 45149] [Qt] V8 port for Qt platform: Qt WebCoreSupport changes : [Attachment 66578] Review comments changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 5 17:10:04 PDT 2010


Andreas Kling <andreas.kling at nokia.com> has denied Vlad <vladbph at gmail.com>'s
request for review:
Bug 45149: [Qt] V8 port for Qt platform: Qt WebCoreSupport changes
https://bugs.webkit.org/show_bug.cgi?id=45149

Attachment 66578: Review comments changes
https://bugs.webkit.org/attachment.cgi?id=66578&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
> +	   Comment out references to JSC.

This isn't a very accurate summary of the changes below.

Patch contents are looking pretty good though like I've said before I'd
personally prefer it without all the unrelated style fixups.
FIXME's are acceptable at this stage IMO, but for longer-term things there
should be bugs opened and referenced in the code.

r- for lack of relevant ChangeLog.


More information about the webkit-reviews mailing list