[webkit-reviews] review granted: [Bug 45240] [Qt] utf8 encoding of console() messages : [Attachment 66599] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 5 16:42:17 PDT 2010


Andreas Kling <andreas.kling at nokia.com> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 45240: [Qt] utf8 encoding of console() messages
https://bugs.webkit.org/show_bug.cgi?id=45240

Attachment 66599: Patch
https://bugs.webkit.org/attachment.cgi?id=66599&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
> +    return StringImpl::create(buffer.toUtf8().constData(),
buffer.toUtf8().length());

This will cause the UTF-8 conversion to be done twice.

r=me, but please fix that before landing.


More information about the webkit-reviews mailing list