[webkit-reviews] review denied: [Bug 45237] Add JSON parameter support to JS/V8 binding generator scripts : [Attachment 66593] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 45237: Add JSON parameter support to JS/V8 binding generator scripts
https://bugs.webkit.org/show_bug.cgi?id=45237

Attachment 66593: Patch
https://bugs.webkit.org/attachment.cgi?id=66593&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66593&action=prettypatch

> WebCore/bindings/scripts/CodeGeneratorJS.pm:235
> +    my $type = shift;
> +    return ("CREATE" => "boolean", "EXCLUSIVE" => "boolean") if $type eq
"Flags";
This logic shouldn't be in the code generator.	You'll need to provide this
information as input to the code generator.

> WebCore/bindings/scripts/CodeGeneratorJS.pm:240
> +    # For testing.
> +    return ("intAttr" => "long",
> +	       "stringAttr" => "DOMString",
> +	       "testObjAttr" => "TestObj") if $type eq "TestJSONObj";
Why do we have special code to support testing?  Doesn't that defeat the
purpose of testing?