[webkit-reviews] review granted: [Bug 42292] Add NetworkingContext to avoid layer violations : [Attachment 66587] Activate NetworkingContext

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 4 12:49:58 PDT 2010


Darin Adler <darin at apple.com> has granted Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 42292: Add NetworkingContext to avoid layer violations
https://bugs.webkit.org/show_bug.cgi?id=42292

Attachment 66587: Activate NetworkingContext
https://bugs.webkit.org/attachment.cgi?id=66587&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> diff --git a/WebCore/platform/network/ResourceHandle.h
b/WebCore/platform/network/ResourceHandle.h
> index d52076c..17d1472 100644
> --- a/WebCore/platform/network/ResourceHandle.h
> +++ b/WebCore/platform/network/ResourceHandle.h
> @@ -29,6 +29,7 @@
>  #include "AuthenticationChallenge.h"
>  #include "AuthenticationClient.h"
>  #include "HTTPHeaderMap.h"
> +#include "NetworkingContext.h"

This file only needs a forward declaration of NetworkingContext. It doesn't
need to include the entire header.

Also, I would expect to see at least one or two cases where we remove includes
of Frame.h or other headers outside the platform directory from the files in
the platform directory.


More information about the webkit-reviews mailing list