[webkit-reviews] review granted: [Bug 45222] Add ability to send UserData to willSubmitForm : [Attachment 66581] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Sam Weinig <sam at webkit.org>'s request for review:
Bug 45222: Add ability to send UserData to willSubmitForm
https://bugs.webkit.org/show_bug.cgi?id=45222

Attachment 66581: Patch
https://bugs.webkit.org/attachment.cgi?id=66581&action=review

------- Additional Comments from mitz at webkit.org
View in context:
https://bugs.webkit.org/attachment.cgi?id=66581&action=prettypatch

> WebKit2/UIProcess/WebPageProxy.h:205
> +    void willSubmitForm(WebFrameProxy* frame, WebFrameProxy* frameSource,
Vector<std::pair<WTF::String, WTF::String> >& textFieldValues, APIObject*,
uint64_t listenerID);
I think it would be helpful to name the argument here.

> WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:45
> +class APIObject;
>  class WebFrame;
>  class WebPage;
> +class ImmutableDictionary;
Please sort.

r=me