[webkit-reviews] review denied: [Bug 45207] [chromium] Implement ImageBufferSkia::draw on the GPU when possible : [Attachment 66572] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 3 17:44:36 PDT 2010
Kenneth Russell <kbr at google.com> has denied James Robinson
<jamesr at chromium.org>'s request for review:
Bug 45207: [chromium] Implement ImageBufferSkia::draw on the GPU when possible
https://bugs.webkit.org/show_bug.cgi?id=45207
Attachment 66572: Patch
https://bugs.webkit.org/attachment.cgi?id=66572&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
This looks better but I noticed one more thing; sorry.
View in context:
https://bugs.webkit.org/attachment.cgi?id=66572&action=prettypatch
> WebCore/html/canvas/CanvasRenderingContext2D.cpp:1286
> + if (!isAccelerated() || !sourceContext ||
!sourceContext->isAccelerated())
For the time being, this needs a more specific check to make sure the source
context is 2D. This won't work for the WebGL code path right now.
More information about the webkit-reviews
mailing list