[webkit-reviews] review denied: [Bug 45207] [chromium] Implement ImageBufferSkia::draw on the GPU when possible : [Attachment 66560] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 3 17:32:03 PDT 2010
Kenneth Russell <kbr at google.com> has denied James Robinson
<jamesr at chromium.org>'s request for review:
Bug 45207: [chromium] Implement ImageBufferSkia::draw on the GPU when possible
https://bugs.webkit.org/show_bug.cgi?id=45207
Attachment 66560: Patch
https://bugs.webkit.org/attachment.cgi?id=66560&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
We've discussed this offline, but in the multisampling case you definitely do
not want to reallocate the color texture into which the blit occurs each frame,
so releaseBackingTexture() is unneeded. Also, getBackingTexture() needs to be
called each time we want to display the up-to-date content in the multisampling
case, so it should probably be named getUpToDateBackingTexture() or similar.
More information about the webkit-reviews
mailing list