[webkit-reviews] review granted: [Bug 44707] Add thirdparty directory and incorporate GLU tessellator : [Attachment 65616] Revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 3 17:00:34 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 44707: Add thirdparty directory and incorporate GLU tessellator
https://bugs.webkit.org/show_bug.cgi?id=44707

Attachment 65616: Revised patch
https://bugs.webkit.org/attachment.cgi?id=65616&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=65616&action=prettypatch

> WebCore/ChangeLog:30
> +	   (dictNewDict):
nit: for new files that are added, it is nice to strip out mention of
the functions included in the new file since they aren't that helpful
when reading a ChangeLog entry like this.  you really just want to
know the set of files being added and the function names just add
noise.	(this was the advice that darin adler gave to me once upon
a time.)

otherwise, R=me


More information about the webkit-reviews mailing list