[webkit-reviews] review granted: [Bug 45160] Add interval tree capable of holding plain old data (POD) : [Attachment 66466] Revised patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 3 16:12:14 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 45160: Add interval tree capable of holding plain old data (POD)
https://bugs.webkit.org/show_bug.cgi?id=45160
Attachment 66466: Revised patch
https://bugs.webkit.org/attachment.cgi?id=66466&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66466&action=prettypatch
> WebCore/platform/graphics/gpu/PODIntervalTree.h:81
> +class PODInterval {
nit: move to a separate header file (PODInterval.h)
> WebCore/platform/graphics/gpu/PODIntervalTree.h:170
> + public PODRedBlackTree<PODInterval<T, UserData> > {
nit: indentation
> WebCore/platform/graphics/gpu/PODIntervalTree.h:336
> +String valueToString(const PODInterval<T, UserData>& interval)
nit: move to PODInterval.h
R=me w/ those changes
More information about the webkit-reviews
mailing list