[webkit-reviews] review requested: [Bug 45134] Added statistics sampling and reporting for JavaScriptCore's RegisterFile and ExecutableAllocator classes : [Attachment 66553] Submission of patch with suggested changes added

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 3 15:04:38 PDT 2010


John Therrell <jtherrell at apple.com> has asked  for review:
Bug 45134: Added statistics sampling and reporting for JavaScriptCore's
RegisterFile and ExecutableAllocator classes
https://bugs.webkit.org/show_bug.cgi?id=45134

Attachment 66553: Submission of patch with suggested changes added
https://bugs.webkit.org/attachment.cgi?id=66553&action=review

------- Additional Comments from John Therrell <jtherrell at apple.com>
-Added link to bug in changelogs
-Renamed functions following suggestion in comments. Function naming follows
FastMalloc statistics naming convention.
-Add comment to explain requirement to call enableStatistics before any
allocations are made in order to reflect accurate, non-negative byte counts.
-Add assertion in FixedVMPoolAllocator that locks are held.
-Removed inline functions following suggestion in comments.


More information about the webkit-reviews mailing list