[webkit-reviews] review granted: [Bug 45124] [chromium] Gracefully switch over to software compositing when layer renderer fails to initialize : [Attachment 66470] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 3 11:37:51 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Vangelis
Kokkevis <vangelis at chromium.org>'s request for review:
Bug 45124: [chromium] Gracefully switch over to software compositing when layer
renderer fails to initialize
https://bugs.webkit.org/show_bug.cgi?id=45124

Attachment 66470: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=66470&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66470&action=prettypatch

> WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:83
> +    PassOwnPtr<LayerRendererChromium> layerRenderer(new
LayerRendererChromium(gles2Context));
nit: this should be changed to use OwnPtr, like so:

  OwnPtr<LayerRenderChromium> layerRenderer(new
LayerRendererChromium(gles2Context));

Then you should use the .release() method of OwnPtr<T> to finally return a
PassOwnPtr<T>.

> WebKit/chromium/src/WebViewImpl.cpp:2110
> +    if (m_compositorCreationFailed)
nit: I think the body of this function should just be changed to:

   return !m_compositorCreationFailed;


R=me with those nits fixed


More information about the webkit-reviews mailing list