[webkit-reviews] review denied: [Bug 45172] Web Inspector: cleanup inspector api. getChildNodes should return children nodes as an output value. : [Attachment 66488] [patch] initial version.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 45172: Web Inspector: cleanup inspector api. getChildNodes should return
children nodes as an output value.
https://bugs.webkit.org/show_bug.cgi?id=45172

Attachment 66488: [patch] initial version.
https://bugs.webkit.org/attachment.cgi?id=66488&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
I don't think it is good idea and would vote to rolling this back. It is
important that all the information is pushed to the DOMAgent.js by means of the
same pushChildren method. Otherwise DOMAgent.js and InspectorDOMAgent may get
easily our of sync. I do realize that API needs to be brushed up, but I'd start
with pushDocument refactorings so that there is no DOM-related traffic unless
requested.