[webkit-reviews] review granted: [Bug 44943] Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint : [Attachment 66366] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 44943: Web Inspector: browser crashes on attempt to evaluate "alert(1)"
while staying on a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=44943

Attachment 66366: Patch
https://bugs.webkit.org/attachment.cgi?id=66366&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
> diff --git
LayoutTests/inspector/debugger-suspend-active-dom-objects-expected.txt
> +Debugger was enabled.
> +Set timer for test function.
> +Script execution paused.
> +Shown alert while staying on a breakpoint
> +Script execution resumed.
> +Debugger was disabled.

Middle line is the only one with a period. Maybe add a period?
I had to have some comment in my review! =)


> +    setTimeout("void 0", 0); // Create a timer that will be suspended on a
breakpoint.

I didn't know that `void` could be used like this. I thought it
needed parens. But, this is valid, so it can be left this way. Cool.


r=me as long as you ran LayoutTests and nothing else failed.