[webkit-reviews] review denied: [Bug 45134] Added statistics sampling and reporting for JavaScriptCore's RegisterFile and ExecutableAllocator classes : [Attachment 66507] 2nd submission of patch w/ style corrections

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 3 10:02:14 PDT 2010


Oliver Hunt <oliver at apple.com> has denied John Therrell <jtherrell at apple.com>'s
request for review:
Bug 45134: Added statistics sampling and reporting for JavaScriptCore's
RegisterFile and ExecutableAllocator classes
https://bugs.webkit.org/show_bug.cgi?id=45134

Attachment 66507: 2nd submission of patch w/ style corrections
https://bugs.webkit.org/attachment.cgi?id=66507&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Can you perf test this -- in general we don't compile in any logging in by
default as JSC has a tendency to be heavily sensitive to branches and register
load (using a global consumes a register as gcc's PIC code is not very clever)


More information about the webkit-reviews mailing list