[webkit-reviews] review denied: [Bug 45157] [Qt][Symbian] V8 port for QT platform: Eliminate ambiguous inclusion of animation.h and CString.h : [Attachment 66453] Eliminate ambiguous inclusion of animation.h and CString.h for Symbian

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Vlad <vladbph at gmail.com>'s request for
review:
Bug 45157: [Qt][Symbian] V8 port for QT platform: Eliminate ambiguous inclusion
of animation.h and CString.h
https://bugs.webkit.org/show_bug.cgi?id=45157

Attachment 66453: Eliminate ambiguous inclusion of animation.h and CString.h
for Symbian 
https://bugs.webkit.org/attachment.cgi?id=66453&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +#if PLATFORM(QT)
> +#include <platform/animation/Animation.h>
> +#else
>  #include "Animation.h"
> +#endif

This is a bad direction -- it does not seem like a good long-term solution to
have platform-specific different ways of including header files. Can we instead
fix the paths passed in to the compiler so that WebCore compiles will find
WebCore headers first, before system headers?

> +#include <wtf/text/CString.h>

We don't want every single file that includes PlatformString to also include
CString. Why is this a good idea?