[webkit-reviews] review granted: [Bug 45044] Add the concept of class methods to bindings (for IndexedDB's IDBKeyRange). : [Attachment 66387] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 3 08:56:48 PDT 2010


Nate Chapin <japhet at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 45044: Add the concept of class methods to bindings (for IndexedDB's
IDBKeyRange).
https://bugs.webkit.org/show_bug.cgi?id=45044

Attachment 66387: Patch
https://bugs.webkit.org/attachment.cgi?id=66387&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
Ok

> +	   // Class methods within JavaScript (like what's used for
IDBKeyRange).
> +	   [V8ClassMethod] void classMethod();
> +	   [V8ClassMethod] long classMethodWithOptional(in [Optional] long
arg);

Is there a good reason for the attribute name to have V8 in it? I know it's
V8-only at the moment, but if it's going to be used across all bindings
eventually, we might want to just drop the 'V8' now.


More information about the webkit-reviews mailing list