[webkit-reviews] review denied: [Bug 43529] [Qt] attributes of Video Tag : [Attachment 66019] Proposed Patch : replaying a video

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 3 05:49:52 PDT 2010


Andreas Kling <andreas.kling at nokia.com> has denied SH <sukhyun.kim at nokia.com>'s
request for review:
Bug 43529: [Qt] attributes of Video Tag
https://bugs.webkit.org/show_bug.cgi?id=43529

Attachment 66019: Proposed Patch : replaying a video
https://bugs.webkit.org/attachment.cgi?id=66019&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
> +	   [Qt] attributes of Video Tag

This makes no sense, please change it (and the bug title) to something
relevant.

> +	   No new tests. (OOPS!)

Oops indeed, it should be easy to make a manual test for this. If you cannot
(or this is already covered by an existing test), please change the above line
to say "No new test because $REASON"

r- because of the lack of test. Change itself looks reasonable.


More information about the webkit-reviews mailing list