[webkit-reviews] review denied: [Bug 45149] [Qt] V8 port for QT platform: QT WebCoreSupport changes : [Attachment 66444] QT WebCoreSupport changes

[bugzilla-daemon at webkit.org]

Andreas Kling <andreas.kling at nokia.com> has denied Vlad <vladbph at gmail.com>'s
request for review:
Bug 45149: [Qt] V8 port for QT platform: QT WebCoreSupport changes
https://bugs.webkit.org/show_bug.cgi?id=45149

Attachment 66444: QT WebCoreSupport changes
https://bugs.webkit.org/attachment.cgi?id=66444&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
> +#if USE(JSC)
>      return JSDOMWindowBase::commonJSGlobalData()->heap.globalObjectCount();
> +#else
> +    // TBD
> +    return 1;
> +#endif

What's the plan for this?

> +#if 0

For disabled code blocks (and workarounds like the above), please include a
comment saying why it's disabled (and if applicable, a bug# where we track any
dependencies of the disabled code.)

This patch then digresses into style cleanups. While nice, please do that in a
separate patch.