[webkit-reviews] review requested: [Bug 26276] Need a mechanism to determine stack extent : [Attachment 66474] interpreteroverflow.diff

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 26276: Need a mechanism to determine stack extent
https://bugs.webkit.org/show_bug.cgi?id=26276

Attachment 66474: interpreteroverflow.diff
https://bugs.webkit.org/attachment.cgi?id=66474&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
First crack at this.

I'm using the same idiom that JSParser uses. I copied the value to calculate an
end address from there, since I'm unsure of whether we want to share it or not.
If we do, we should probably have it in some header (where?), if we want a
different value here we just need to change it.

WRT tests, there's actually a few tests that check for stack overflow in
parsing, execution, ...(eg, js1_5/Regress/regress-192414.js,
js1_5/Regress/regress-192465.js ), but we could write more if you think our
coverage is not enough. In any case, no regressions here with this patch.