[webkit-reviews] review granted: [Bug 45006] Add AudioListener files : [Attachment 66141] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 45006: Add AudioListener files
https://bugs.webkit.org/show_bug.cgi?id=45006

Attachment 66141: Patch
https://bugs.webkit.org/attachment.cgi?id=66141&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Looks fine to me. I was going to argue about the naming of setOrientation
taking the six double arguments, but see that that's exposed in the JavaScript
API. It might be worth a FIXME at the top to change this to using FloatPoint3D
rather than Vector3 once FloatPoint3D has been moved to a more general place
than platform/graphics. (Or you could just cut it over now in anticipation of
the move.) You could also consider switching over to single-precision floating
point numbers everywhere in the implementation if they provide sufficient
precision and range.