[webkit-reviews] review requested: [Bug 45059] Add red-black tree capable of holding plain old data (POD) : [Attachment 66421] Revised patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 2 15:29:59 PDT 2010
Kenneth Russell <kbr at google.com> has asked for review:
Bug 45059: Add red-black tree capable of holding plain old data (POD)
https://bugs.webkit.org/show_bug.cgi?id=45059
Attachment 66421: Revised patch
https://bugs.webkit.org/attachment.cgi?id=66421&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
Addressed review feedback from fishd:
- include stdint.h.
- Made destructors protected and WTF::RefCounted<T> a friend.
- Renamed alloc to allocateObject.
- Used WTF_ALIGN_OF in minAlignment.
- Added const to all conceptually const methods.
- Grouped NDEBUG includes.
- Renamed kRed and kBlack.
- Added helper function for LOG_ERROR with m_verboseDebugging on.
More information about the webkit-reviews
mailing list