[webkit-reviews] review denied: [Bug 45133] [chromium] Make a public flag for how DRT generates bitmaps on Linux : [Attachment 66413] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Tony Chang
<tony at chromium.org>'s request for review:
Bug 45133: [chromium] Make a public flag for how DRT generates bitmaps on Linux
https://bugs.webkit.org/show_bug.cgi?id=45133

Attachment 66413: Patch
https://bugs.webkit.org/attachment.cgi?id=66413&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66413&action=prettypatch

> WebKit/chromium/public/DumpRenderTreeDefaults.h:36
> +extern const bool makeLinuxChecksumOpaque;
it seems like this would be better done without a globally exported variable.
how about a setter and a getter in the usual fashion?  also, why the
DumpRenderTree
namespace in the WebKit API's public directory?

can you just place these methods in WebKit.h next to
setLayoutTestMode/layoutTestMode?