[webkit-reviews] review requested: [Bug 44088] [Qt] Add API to QWebSettings for setting/getting the padding of HitTestResult : [Attachment 66414] patch v2

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has asked	for review:
Bug 44088: [Qt] Add API to QWebSettings for setting/getting the padding of
HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=44088

Attachment 66414: patch v2
https://bugs.webkit.org/attachment.cgi?id=66414&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
(In reply to comment #8)
> (From update of attachment 64548 [details])
> WebKit/qt/Api/qwebsettings.h:142
>  +	  void setHitTestPadding(Qt::Orientation, int padding);
>
> Hmm, this is a member function of QWebSettings, but it actually doesn't
change any members but reads/writes directly to the global settings. I think it
should either be a static function or the setting should propagate correct from
global settings to page specific settings.

Addressed with Simon's first suggestion here: made methods static functions.

@Simon: at the moment I did not have a maemo6 device to test it, but n900
(maemo5). It would be great if it could get tested together with patch in bug
44089. Touch interaction result should be really better.

@Benjamin: I understand your concern that we could be favoring elements above
the touch point, as mozilla makes it possible to set with their API, but would
the gain be a difference. API would be simpler as is, and it'd be great with we
could keep it as is.

Again, real testing would answer these questions.