[webkit-reviews] review requested: [Bug 45127] [GTK][Soup] implement local directory listing. : [Attachment 66407] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 2 13:54:12 PDT 2010


arno. <arno at renevier.net> has asked  for review:
Bug 45127: [GTK][Soup] implement local directory listing.
https://bugs.webkit.org/show_bug.cgi?id=45127

Attachment 66407: patch v1
https://bugs.webkit.org/attachment.cgi?id=66407&action=review

------- Additional Comments from arno. <arno at renevier.net>
Here is a first attempt:
As there already exist a FTPDirectoryDocument, I choose to use it.
So, soup backend set mime type to application/x-ftp-directory and sends data
similar to a ftp directory. 
I discovered in FTPDirectoryParser.cpp there are many ftp listing formats, so I
choose EPLF because it's the first one checked in parseOneFTPLine. I don't
known if it's good choice especially since it's currently broken (bug #45113),
but that can probably be easily changed.

If the trick of using application/x-ftp-directory mime type is not a good idea,
may be we can create a LocalDirectoryDocument, and create our own scheme, or we
can also use mozilla's dir index format.
http://www.mozilla.org/projects/netlib/dirindexformat.html (but may it's better
to not have two kind of parsers and documents for ftp and local directories)


More information about the webkit-reviews mailing list