[webkit-reviews] review denied: [Bug 45020] Support "block-flow" and "writing-mode": interpret properties into RenderStyle : [Attachment 66174] Proposed patch file

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Takumi Takano
<takano1 at asia.apple.com>'s request for review:
Bug 45020: Support "block-flow" and "writing-mode": interpret properties into
RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=45020

Attachment 66174: Proposed patch file
https://bugs.webkit.org/attachment.cgi?id=66174&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This patch is missing the "bt" value for the block-flow property.  I only see
"tb", "rl" and "lr".

I'd prefer descriptive names for the block flow direction rather than the
abbreviations.	Instead of BFLR, BFLR, BFTB, I'd prefer:

LeftToRightBlockFlow, RightToLeftBlockFlow, TopToBottomBlockFlow,
BottomToTopBlockFlow

I would go ahead and add computed style support (see
CSSComputedStyleDeclaration) for the new properties to this patch, since that
will enable you to have actual tests that verify that the values are being
parsed and inherited correctly.